Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rafactor header store for v.0.2 #10

Closed
wants to merge 10 commits into from
Closed

Rafactor header store for v.0.2 #10

wants to merge 10 commits into from

Conversation

sqrlfirst
Copy link
Contributor

@sqrlfirst sqrlfirst commented Jun 12, 2024 •
edited
Loading

refactor logic simupar to mmr_verifier

@sqrlfirst
Copy link
Contributor Author

Hey @ametel01! Could you please look at PR? I have some weird compile errors connected with linking of mmr_verifier. Also to set a block_state_root what block_number we should use? One provided in encoded_block or latest_l1_block_number ?

ametel01
ametel01 requested changes Jun 25, 2024
View reviewed changes
starknet/src/L1_headers_store/contract.cairo Show resolved Hide resolved
starknet/src/library/mmr_verifier.cairo Outdated Show resolved Hide resolved
starknet/src/library/mmr_verifier.cairo Outdated Show resolved Hide resolved
@ametel01
Copy link
Collaborator

Also you need to make the fields of struct MMRProof public

@ametel01 ametel01 closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ametel01 ametel01 ametel01 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sqrlfirst @ametel01 @hakymulla