FIX: Error writing files of exact size 0xffffffff on Windows

resolves: Oldes/Rebol-issues#2282
Oldes · Jul 5, 2022 · 3c43f44 · 3c43f44
1 parent 39347f4
commit 3c43f44
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/src/os/win32/dev-file.c b/src/os/win32/dev-file.c
@@ -387,8 +387,10 @@ static BOOL Seek_File_64(REBREQ *file)
  size_low = GetFileSize(file->handle, &size_high);
  if (size_low == 0xffffffff) {
  result = GetLastError();
- file->error = -RFE_BAD_WRITE;
- return DR_ERROR;
+ if (result != NO_ERROR) {
+ file->error = -RFE_BAD_WRITE;
+ return DR_ERROR;
+ }
  }
 
  file->file.size = ((i64)size_high << 32) + (i64)size_low;

diff --git a/src/tests/test-issue-2282.r3 b/src/tests/test-issue-2282.r3
@@ -0,0 +1,21 @@
+Rebol [
+ Title: "Test for issue #2282"
+ Url: https://github.com/Oldes/Rebol-issues/issues/2282
+]
+
+file: %issue-2282
+try [delete file]
+print either all [
+ not error? try [
+ a: make binary! n: 268435391
+ insert/dup a #"a" n
+ loop 16 [write/append file a]
+
+ b: make binary! n: 1039
+ insert/dup b #"b" n
+ write/append file b
+ ]
+ (size? file) = to integer! #{FFFFFFFF}
+]["OK"]["FAILED"]
+wait 1
+try [delete file]