Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 bit: fix test failures #27

Conversation

fzi-haxel
Copy link

@fzi-haxel fzi-haxel commented Dec 22, 2023

Contribution description

  • flashpage-test: Fixed print format and removed C preprocessor if statement.
    sizeof(uintptr_t) == sizeof(uint32_t) does not imply PRIx32 == PRIxPTR.
    While it worked for x86-gcc, the arm-gcc resolves uintptr_t to unsigned int and uint32_t to unsigned long.
  • sys: Swapped PRIuSIZE format specifiers
  • tests-uri_parser.c: Readded missing unsigned cast
  • tests-fib.c: Reverting size_t to unsigned type change for add_buf_size due to fib_get_next_hop(..., &add_buf_size, ...) call. I was a bit to eager with this change

Testing procedure

flashpage-test: BOARD=iotlab-m3 make -C tests/periph/flashpage
Others: Compiled all examples and tests for avr-rss2, iotlab-m3, esp32-wroom-32, native and "native64"

@fzi-haxel fzi-haxel force-pushed the 64bit-preparation-for-oleg branch from f6981dd to e46d674 Compare December 22, 2023 07:18
@fzi-haxel fzi-haxel changed the title flashpage-test: fix print format error 64 bit: fix test failures Dec 22, 2023
sys/net/gnrc/pktbuf_static/gnrc_pktbuf_static.c Outdated Show resolved Hide resolved
sys/net/gnrc/pktdump/gnrc_pktdump.c Outdated Show resolved Hide resolved
@fzi-haxel fzi-haxel force-pushed the 64bit-preparation-for-oleg branch from e46d674 to 76e928a Compare December 23, 2023 08:13
@fzi-haxel
Copy link
Author

Added changes a separate PR.

@fzi-haxel fzi-haxel closed this Jan 15, 2024
@fzi-haxel fzi-haxel deleted the 64bit-preparation-for-oleg branch January 15, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants