Meaningful error messages when get_group() and get_event() lookups fail.
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiminhp
reviewed
Apr 23, 2024
maiminhp
reviewed
Apr 23, 2024
maiminhp
reviewed
Apr 23, 2024
|
Great! Looks good, but I have no time to really test it out for a while. But if you feel comfortable, I trust you to merge it |
|
Thanks - I am sure there are minor tweaks that can be made to the test code, e.g. by generalising the mocked |
…s fail. Add coverage in manual end-to-end test suite.
…ew `test_spond.py` pytest suite
elliot-100
force-pushed
the
improve-lookup-errors
branch
from
b3b9b89 to
e5fb2f3
Compare
|
Note force-pushing was a error, I should have just merged in b337d64 then pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add coverage in manual end-to-end test suite and misc. output improvements