Changed: raise KeyError instead of IndexError for all failed lookup methods
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, should be be changing to 'KeyError' of course. Will revise. |
…up methods; for `get_person()`,also make error message more meaningful and add Raises to docstring.
elliot-100
force-pushed
the
113-raise-keyerror-for-failed-lookup-by-id
branch
from
8f65a3c to
5263e15
Compare
elliot-100
changed the title
LookupError instead of IndexError for all failed lookup methodsKeyError instead of IndexError for all failed lookup methods
|
Is it OK if I merge this @Olen? |
|
Looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
get_person(), also make error message more meaningful and add 'Raises' to docstring.