Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for Spond and SpondClub __init__() methods. #140

Conversation

elliot-100
Copy link
Collaborator

@elliot-100 elliot-100 commented Jun 25, 2024

This is a key 'missing piece' that should enable static type-checkers (e.g. mypy or IDE tools) to analyse the code fully, and help resolve more complex issues.

@elliot-100 elliot-100 linked an issue Jun 25, 2024 that may be closed by this pull request
@elliot-100 elliot-100 merged commit d9c6869 into Olen:main Jun 26, 2024
5 checks passed
@elliot-100 elliot-100 deleted the 139-add-type-hints-to-spond-and-spondclub-__init__-methods branch June 26, 2024 10:14
@elliot-100
Copy link
Collaborator Author

I've gone ahead and merged this one @Olen, as it has no run-time impact, and as type hints aren't enforced, is really just a form of documentation. Hope that's OK.

@Olen
Copy link
Owner

Olen commented Jun 26, 2024

I fully trust your judgement on all of these, @elliot-100

With a community it seems like this is building right now, I hope more eyes will catch more errors.
I very much want to participate, and especially in the more high level discussions or bigger changes, but for me it is fine to do cleanups, corrections, clarifications etc. without waiting for my approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type hints to Spond and SpondClub __init__() methods
2 participants