-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to write posts and polls #38
base: main
Are you sure you want to change the base?
Conversation
Sorry, did not see this review-request. One question (not directly related to this PR) was wether we should start doing more error checking on the "write" operations, as I see there are more coming in. We could (should?) start validating the results from functions lke these two, and also Another question is if the prefix "write" is the best.
Or is it better to have more "natural language" with send message, write post add event? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with the changes, but please see my general comment to the PR regarding naming av validation of write-requests.
On the naming issue, I have a slight preference for using "create_" consistently. I've put this back to 'draft' status as it seems to need more thought. |
@amaurylekens In the process of creating a post - did you investigate the option to add an attachment to this post by first posting a file towards the route /storage/upload and then use this resulting media as an attachment in the post to be created? Creating a post is quite straight forward, but the usage of /storage/upload unfortunately is not. |
@amaurylekens or @Olen do you plan to progress this? |
I have no immediate plans to work on this, but if the PR is updated and aligned with the rest of the changes that have been suggested and implemented lately, I obviously don't have any objections to the intent of the PR. |
Add two methods: