Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added update_event function #56

Merged
merged 2 commits into from
Feb 10, 2023
Merged

added update_event function #56

merged 2 commits into from
Feb 10, 2023

Conversation

olizimmermann
Copy link
Contributor

Just added an update option for events. Submitting soon a create function as well.

Cheers

Copy link
Owner

@Olen Olen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking and wanting to hear your opinion. Would it be better if the function fetched the original event itself?
If you always have to supply the original event in addition to the changes, this sounds to me like a better way than having to do it manually before creating the changes?

@olizimmermann
Copy link
Contributor Author

Good idea. Let me test it.

@Olen
Copy link
Owner

Olen commented Jan 27, 2023

If you like, please also look at #57 and add some comments.

@olizimmermann
Copy link
Contributor Author

@Olen updated it :)

@elliot-100 elliot-100 mentioned this pull request Feb 8, 2023
@Olen Olen merged commit f0c90d9 into Olen:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants