-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added option to start a new chat or continue old one #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. But I think we should either merge it with the current send_message
or give it a different name, so it is more clear where the two functions differ.
And could we simplify the two functions if they are mergeable, so it could somehow autodetect if the recepient is a chat_id, a group_uid or a user?
Ok, let me check the options here. |
Decided to merge both send_message functions. If you provide a chat_id, the continue_chat function will be called. |
Oops. I meant a dict with a class object inside (like str) cannot be converted to json. That's why I choose None instead. |
@olizimmermann or @Olen do you plan to progress this? I don't know enough about chats myself. |
What exactly do you need? Check out my latest PR #62. @elliot-100 |
Can you resolve the conficts in your branch? I think I can then merge it. |
Thanks @olizimmermann! @Olen I've gone ahead and merged since you already reviewed the bulk of this - hope that's OK. |
No description provided.