Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to start a new chat or continue old one #62

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

olizimmermann
Copy link
Contributor

No description provided.

Copy link
Owner

@Olen Olen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. But I think we should either merge it with the current send_message or give it a different name, so it is more clear where the two functions differ.

And could we simplify the two functions if they are mergeable, so it could somehow autodetect if the recepient is a chat_id, a group_uid or a user?

@olizimmermann
Copy link
Contributor Author

Ok, let me check the options here.

@olizimmermann
Copy link
Contributor Author

Decided to merge both send_message functions. If you provide a chat_id, the continue_chat function will be called.
Also updated the update_event function. Needed to replace None with an empty String, because I saw, that some events doesn't provide all fields and a dict with a None field inside, cannot be converted to json.

@olizimmermann
Copy link
Contributor Author

Oops. I meant a dict with a class object inside (like str) cannot be converted to json. That's why I choose None instead.

@elliot-100
Copy link
Collaborator

@olizimmermann or @Olen do you plan to progress this? I don't know enough about chats myself.

@olizimmermann
Copy link
Contributor Author

olizimmermann commented Jul 15, 2023

What exactly do you need? Check out my latest PR #62. @elliot-100

@elliot-100
Copy link
Collaborator

Can you resolve the conficts in your branch? I think I can then merge it.

@elliot-100 elliot-100 merged commit 7402000 into Olen:main Jul 17, 2023
@elliot-100
Copy link
Collaborator

Thanks @olizimmermann! @Olen I've gone ahead and merged since you already reviewed the bulk of this - hope that's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants