Emphasize permitted version format in packages for publication #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlenaYefymenko
force-pushed
the
322-doc-version-format-for-publication
branch
from
1bc675a
to
76d1a13
Compare
OlenaYefymenko
changed the title
|
@webknjaz, could you please review the updated PR and provide your feedback? |
webknjaz
reviewed
May 8, 2023
webknjaz
reviewed
May 8, 2023
webknjaz
reviewed
May 8, 2023
OlenaYefymenko
force-pushed
the
322-doc-version-format-for-publication
branch
from
db66bb6
to
3eb3ce3
Compare
OlenaYefymenko
force-pushed
the
322-doc-version-format-for-publication
branch
from
23ae525
to
dc4879c
Compare
webknjaz
reviewed
May 29, 2023
README.rst
Outdated
| package indexes like PyPI or TestPyPI. The disallowed version segments may | ||
| be seen in auto-publishing workflows or when a configuration mistake is made. | ||
|
|
||
| However, if you need to use local version identifiers in your packages, you |
There was a problem hiding this comment.
I think that we shouldn't suggest people to use devpi just for the local version. This motivation is probably wrong. Instead, mention that some indexes, like devpi, allow those.
OlenaYefymenko
force-pushed
the
322-doc-version-format-for-publication
branch
from
dc4879c
to
6f3bfa6
Compare
The patch adds mention in README that local version identifiers in packages don't allow publishing to PyPI/TestPyPI. Also, it suggests alternative local servers for using local version identifiers. Resolves pypa#322 Co-authored-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
OlenaYefymenko
force-pushed
the
322-doc-version-format-for-publication
branch
from
6f3bfa6
to
b6c0412
Compare
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch adds mention in README that local version identifiers in packages don’t allow publishing to PyPI/TestPyPI. Also, it suggests alternative local servers for using local version identifiers.
Resolves pypa#322