Skip to content

v1.3.3

Pre-release
Pre-release
Compare
Choose a tag to compare
@Olf0 Olf0 released this 17 Feb 00:44
· 125 commits to master since this release
1.3.3
c2d1ef4
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Changes

  • Fix an incorrect use of EnvironmentFile=.
  • Making unmounting more fail-safe by creating a "safety net", utilising umount -q.
  • Also decouple mount-sdcard (respectively its mount-sd@.service) from udisks2.service (or any other component of udisks2) failing, as udisks is now only necessary for mounting, but a weak dependency thereafter with aforementioned "safety net" (as long as a mount proper survives, which is on behalf of the kernel, not udisks).

Background

mount-sdcard (respectively mount-sd@.service, both SailfishOS' original and the one deployed by mount-sdcard) utilises udisksctl mount to mount a partition on behalf of a user, as there is no other proper way to achieve this and that is exactly what udisks is made for. While unmounting should follow the same route backwards (via udisksctl unmount), it does not absolutely have to, a "last resort unmounting" per umount also works.
Thus the strength of the dependency to udisks2.service was downgraded from BindsTo= to Requires= (still in combination with After=), an ExecStopPost=/bin/umount -vq /dev/%i introduced (the "safety net" proper) and a Conflicts=umount.target added (see comment in mount-sd@.service for details).

Assets 4
Loading