guile: append stray output to log #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks to see if there was a result found and if so gathers all text from after the end of the last prompt until '$n = ...'. If not then everything from the last prompt up until the next is gathered. In either scenario the stray text is appended to Conjure's log. This makes the Guile client more consistent with the built-in Fennel client. Also, this uses Fennel's support for multiple cond/body pairs within if forms thus removing a nested if.
|
Oh wonderful! Thank you! Taking a look now. |
|
Tested locally and it's working, however as you said in the original issue it doesn't cover muti value returns. I think we might need a bit of a rethink about how this works if we want to address all of the issues. This is a good incremental improvement though. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks to see if there was a result found and if so gathers all text from after the end of the last prompt until
$n = .... If not then everything from the last prompt up until the next is gathered. In either scenario the stray text is appended to Conjure's log. This makes the Guile client more consistent with the built-in Fennel client.Also, this uses Fennel's support for multiple cond/body pairs within if forms thus removing a nested if.
This is a possible fix for #412