Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc-str Guile #563

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix doc-str Guile #563

merged 1 commit into from
Mar 11, 2024

Conversation

DMClVG
Copy link
Contributor

@DMClVG DMClVG commented Mar 11, 2024

doc-str would silently fail and not display anything in nvim when used with Guile due to a missing check on the optional opts.on-result property. This PR fixes it

Copy link
Owner

@Olical Olical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks like a good fix. I would use a when instead of an if when it's a single branch though, I'll correct that post-merge happily because this is still fine Fennel, just would fail linting if such linting existed. (maybe it does!)

@Olical Olical changed the base branch from master to develop March 11, 2024 22:25
@Olical Olical merged commit de77094 into Olical:develop Mar 11, 2024
2 checks passed
@DMClVG
Copy link
Contributor Author

DMClVG commented Mar 11, 2024

You're right. Force of habit lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants