Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bed and Extruder temperature placeholders for messages #210

Open
sbussinger opened this issue Feb 25, 2021 · 9 comments
Open

Add Bed and Extruder temperature placeholders for messages #210

sbussinger opened this issue Feb 25, 2021 · 9 comments

Comments

@sbussinger
Copy link

It would be really nice if there were bed and extruder temperature keywords in the list of placeholders used in messages. I'd like to have the temperatures in the NavigationBar and would prefer not to install another plugin to do it when I'm using DisplayLayerProgress to modify the NavigationBar already.

@stale
Copy link

stale bot commented Mar 27, 2021

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Mar 27, 2021
@OllisGit
Copy link
Owner

OllisGit commented Apr 4, 2021

Hi @sbussinger,

there is no server-side event for the temp-change, so I need to implement a timer for reading the current temp.

How often do you need a temp update in the UI e.g. is every 10 seconds enough?

@OllisGit OllisGit added status: waitingForFeedback Wating for Customers feedback and removed status: markedForAutoClose Issue will be closed automatically labels Apr 4, 2021
@sbussinger
Copy link
Author

Every 10 seconds would be fine. A configuration setting would be nice I suppose, but not important for me. If I want real-time readings I can go to the temperature tab. But if adding timer support to the plugin is a big deal, I'd say skip this request. I thought perhaps it'd be easy to add along side existing stuff, if it's not simple then this isn't worth your time.

Thanks!

@stale
Copy link

stale bot commented May 5, 2021

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label May 5, 2021
@OllisGit OllisGit added feature: updateByTime status: analysing and removed status: markedForAutoClose Issue will be closed automatically status: waitingForFeedback Wating for Customers feedback labels May 10, 2021
OllisGit added a commit that referenced this issue Jan 26, 2022
- E #210 Bed/Tool-Temperatures
- E #251 Release Channel and Stale-Action
@OllisGit
Copy link
Owner

Hi @sbussinger,

in the latest version 1.28.0 you can output the temperatures where ever you like ;-)

Please test and give feedback.

Thx,
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Jan 26, 2022
@sbussinger
Copy link
Author

That's awesome, thank you very much! This is great!

Feedback:

  1. Perhaps limit the temperature displays to 1 decimal point accuracy instead of 2 to match the numbers shown on the Temperature tab. Also the 0.01° resolution causes the number to fluctuate more than it needs to.
  2. I have enabled the option to append the actual bed temperature to the browser tab title and it's blinking on and off erratically (I don't recall this behavior before).

Again, thank you. It's much appreciated!

@OllisGit
Copy link
Owner

Hi @sbussinger,
the first point will be in the next release.

The second point I am not able to reproduce.

  • What browser do you use?
  • What DLP-Settings do you use? Is the blinking invervall like the "Toggle Printer Display Message" time?

@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: analysing labels Mar 23, 2022
@sbussinger
Copy link
Author

On the second point, I normally use Edge, but it does the same thing on Firefox. I'll attach a short screen video showing the effect. It's not a regular pattern of blinking as far as I can tell, it's more random.

20220323130510.mp4

I've had the Output Interval set to 0. I tried setting it to 5 seconds and it had no obvious effect, so I've set it back to 0. I don't have an LCD on the printer so I don't have the printer display stuff enabled.

This is not a big deal and not worth spending a lot of time on.

OllisGit added a commit that referenced this issue Jul 11, 2022
- E #265 show next filament change layer
- B #257 fixing relative height movement
- B #210 reduce temperature resulution and fixing blinking of bed temperature
@OllisGit
Copy link
Owner

Hi @sbussinger,
thanks for the video was very helpful.

My assumption is that reading all temperatures from the printer that sometimes the bed-temperature is not always in the "response". So, I now store the last bed-temperature and if the current temperature could not read, I display the last readed temperature instead.

This is implemented and now available in version 1.29.0rc1.

If you are using OP 1.8.x you can switch between the release-channels via "Software Update" menu.
Or you can reinstall the version via plugin manager: https://github.com/OllisGit/OctoPrint-DisplayLayerProgress/releases/download/1.29.0rc1/master.zip

Please test and give feedback.

Thx, in advance
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants