Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"layer indicator not found" for files with thumbnail image #221

Closed
MAhlborg opened this issue Apr 11, 2021 · 4 comments
Closed

"layer indicator not found" for files with thumbnail image #221

MAhlborg opened this issue Apr 11, 2021 · 4 comments
Labels
status: markedForAutoClose Issue will be closed automatically type: enhancement New feature or request

Comments

@MAhlborg
Copy link

I use Prusa Slicer and I embed thumbnails in my gcode files. Sometimes the DisplayLayerProgress-Plugins works, sometimes it fails with "No layer indicator found in the first 500 lines". I had a look at my files and it seems, with embedded thumbnails, the actual gcode starts after line 500, so the plugin gives up, even when there are M117 lines present.

Is it possible to increase the line limit for the indicator search? I think, it should be at least be 600, but 1000 would be even better.

Thanks,
Best regards,
Martin
@OllisGit
Copy link
Owner

Hi @MAhlborg,

I increased the limit to 750 lines and added the option to adjust the number.

image

Will be in the next release.

@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: inProgress labels Oct 14, 2021
OllisGit added a commit that referenced this issue Oct 14, 2021
@OllisGit
New Version 1.27.0
745b594 
- E #230 fire event when m600 occurs
- E #224, #182 adjustable current time format
- E #222 Option to disable "Layer indicator not found" popup
- E #221 Option to change "look ahead" line count
- B #213 filter empty lines from layer-expressions
- PR #234 typo, credit goes to @2231puppy
- PR #238 Added built-in support for Prusa layer counting, credit goes to @scyto

- reducing size of master.zip
@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Oct 14, 2021
@OllisGit
Copy link
Owner

Hi @MAhlborg ,

the new release 1.27.0 with this feature is out now.
Please test and give feedback.

Thx, in advance
Olli

@stale
Copy link

stale bot commented Nov 14, 2021

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Nov 14, 2021
@stale stale bot closed this as completed Nov 24, 2021
@MAhlborg
Copy link
Author

Sorry for being late, was very busy. I can confirm that the plugins works perfectly now in connection with thumbnails. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: markedForAutoClose Issue will be closed automatically type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OllisGit @MAhlborg