Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTUDIO-2728: Add keyboard navigation of entries #162

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

maxfrederiksen-ess
Copy link
Collaborator

Summary of Changes

  • Added new hook for listening to keypress events
  • Refactored and added new logic to accommodate keyboard navigation of entries

@georgweiss
Copy link
Member

Approved, but I got the following when starting
Line 64:6: React Hook useEffect has missing dependencies: 'currentLogEntryId', 'keyboardNavigate', and 'setDefaultLogEntry'. Either include them or remove the dependency array react-hooks/exhaustive-deps
Line 71:6: React Hook useEffect has missing dependencies: 'currentLogEntryId', 'keyboardNavigate', and 'setDefaultLogEntry'. Either include them or remove the dependency array react-hooks/exhaustive-deps

@maxfrederiksen-ess
Copy link
Collaborator Author

Approved, but I got the following when starting Line 64:6: React Hook useEffect has missing dependencies: 'currentLogEntryId', 'keyboardNavigate', and 'setDefaultLogEntry'. Either include them or remove the dependency array react-hooks/exhaustive-deps Line 71:6: React Hook useEffect has missing dependencies: 'currentLogEntryId', 'keyboardNavigate', and 'setDefaultLogEntry'. Either include them or remove the dependency array react-hooks/exhaustive-deps

Thanks, only warnings but will fix those after rebase 👍

@maxfrederiksen-ess maxfrederiksen-ess merged commit 768ff76 into main Nov 1, 2024
3 of 6 checks passed
@maxfrederiksen-ess maxfrederiksen-ess deleted the CSSTUDIO-2728-keyboard-navigation branch November 1, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants