use the gonsForBalance function in transfer function of sOlympusE…
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RC20.sol, instead of writing the code again The first line of transfer function in the sOlympusERC20.sol contract calculates the gonValue of the given fragments representated by the value parameter. The contract has a function `gonsForBalance` for this purpose and using this can help maintain consistency in the codebase and can help avoid any bugs in future if `gonsForBalance` goes through some change! old code => ``` uint256 gonValue = value.mul( _gonsPerFragment ); ``` new change => ``` uint256 gonValue = gonsForBalance(value); ```
|
can someone please review this 👀 |
|
smart! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…RC20.sol, instead of writing the code again
The first line of the
transferfunction in the sOlympusERC20.sol contractcalculates the gonValue of the given fragments represented by the
valueparameter.The contract has a function
gonsForBalancefor this purpose and usingthis can help maintain consistency in the codebase and can help avoid
any bugs in the future if
gonsForBalancegoes through some change!old code =>
new change =>