add comments, clean some stuff up, gas optimisations #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations:
Pickup some low hanging fruit fixes and changes before auditors look at it. They should focus on security and gas optimisations we missed, should not have to have them find heaps of minor things we could have saw coming already like not putting natspec on some functions.
Changes:
-Removed some unneeded fields in events. E.g currentdebt in event of paying debt with collateral is always going to be 0 so not really needed.
-Allow borrower split into allow LP and allow Non LP Borrower. Makes it easier to call the functions, not needing to know which to put true or false but just call the right functions. Also function is smaller with less checks so more gas efficient.
-Revoke borrower doesn't really need to know what type of borrower they are it revokes same anyway.
-Natspec when there not there
-Few minor stuff here and there