Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check API call also returns failing builds #2079

Closed
Unimatrix0 opened this issue Mar 15, 2018 · 0 comments
Closed

Update check API call also returns failing builds #2079

Unimatrix0 opened this issue Mar 15, 2018 · 0 comments

Comments

@Unimatrix0
Copy link
Contributor

Ombi build Version:

V 3.0.3033

Update Branch:

Develop

Operating System:

Ubuntu 16.04.4 LTS

Ombi Applicable Logs (from /logs/ directory or the Admin page):

From /api/v1/Update/develop:
{"updateVersionString":"3.0.3038","updateVersion":30,"updateDate":"2018-03-15T11:08:34.7724524-05:00","changeLogs":[{"type":"New","descripion":"Small memory improvements in the Plex Sync. [Jamie]\n"},{"type":"New","descripion":"Fixed the sort issue on the user Management page. Also added sorting to the Movie Requests page. [tidusjar]\n"},{"type":"New","descripion":"Downgraded the angular2-jwt library since it has a bug in it. #2064. [tidusjar]\n"},{"type":"New","descripion":"Fixed an issue when Plex decideds to reuse the Plex Key for a different media item... #2038. [tidusjar]\n"},{"type":"New","descripion":"Fixed an issue where we might show the Imdb link when we do not have a imdbid #1797. [tidusjar]\n"},{"type":"New","descripion":"Fixed the issue where we can no longer select Pending Approval in the filters #2057. [tidusjar]\n"},{"type":"New","descripion":"Fixed the API key not working when attempting to get requests #2058. [tidusjar]\n"},{"type":"New","descripion":"Fixed #2056. [tidusjar]\n"},{"type":"New","descripion":"Experimental, set the Webpack base root to the ombi base path if we have it. This should hopefully fix the reverse proxy issues. [Jamie]\n"},{"type":"Fixed","descripion":"New Features"}],"downloads":[]}

From https://ci.appveyor.com/api/projects/tidusjar/requestplex/build/3.0.3038:
{"project":{"projectId":173229,"accountId":20518,"accountName":"tidusjar","builds":[],"name":"Ombi","slug":"requestplex","repositoryType":"gitHub","repositoryScm":"git","repositoryName":"tidusjar/Ombi","repositoryBranch":"DotNetCore","isPrivate":false,"skipBranchesWithoutAppveyorYml":false,"enableSecureVariablesInPullRequests":false,"enableSecureVariablesInPullRequestsFromSameRepo":false,"enableDeploymentInPullRequests":false,"saveBuildCacheInPullRequests":false,"rollingBuilds":false,"rollingBuildsDoNotCancelRunningBuilds":false,"rollingBuildsOnlyForPullRequests":false,"alwaysBuildClosedPullRequests":false,"tags":"","nuGetFeed":{"id":"requestplex-u0em166wqa8r","name":"Project RequestPlex","accountId":20518,"projectId":173229,"isPrivateProject":false,"publishingEnabled":false,"created":"2016-02-26T14:19:26.0049553+00:00"},"securityDescriptor":{"accessRightDefinitions":[{"name":"View","description":"View"},{"name":"RunBuild","description":"Run build"},{"name":"Update","description":"Update settings"},{"name":"Delete","description":"Delete project"}],"roleAces":[{"roleId":30248,"name":"Administrator","isAdmin":true,"accessRights":[{"name":"View","allowed":true},{"name":"RunBuild","allowed":true},{"name":"Update","allowed":true},{"name":"Delete","allowed":true}]},{"roleId":30249,"name":"User","isAdmin":false,"accessRights":[{"name":"View"},{"name":"RunBuild"},{"name":"Update"},{"name":"Delete"}]}]},"created":"2016-02-26T14:19:24.4731674+00:00","updated":"2017-10-17T15:29:13.3603475+00:00"},"build":{"buildId":14536715,"jobs":[{"jobId":"de5widyumxr6sxoo","name":"","osType":"Windows","allowFailure":false,"messagesCount":0,"compilationMessagesCount":0,"compilationErrorsCount":0,"compilationWarningsCount":0,"testsCount":0,"passedTestsCount":0,"failedTestsCount":0,"artifactsCount":0,"status":"failed","started":"2018-03-15T13:27:22.0898676+00:00","finished":"2018-03-15T13:32:32.2111477+00:00","created":"2018-03-15T13:24:25.1541666+00:00","updated":"2018-03-15T13:32:32.2111477+00:00"}],"buildNumber":3038,"version":"3.0.3038","message":"Added the ability to refresh out backend metadata (#2078)","messageExtended":"We now can refresh the Plex Metadata in our database. For example if the Plex Agent for TV Shows is TheMovieDb, we will use that and populate the IMDB Id and TheTvDb Id's so we can accuratly match and search things.\n\nAlso improved the Job settings page so we can Test CRON's and we also validate them.","branch":"develop","isTag":false,"commitId":"47f66978f00dc16ecd3c8adc0e0588b5c205a61e","authorName":"Jamie","authorUsername":"tidusjar","committerName":"GitHub","committerUsername":"web-flow","committed":"2018-03-15T13:24:20+00:00","messages":[],"status":"failed","started":"2018-03-15T13:27:22.6211043+00:00","finished":"2018-03-15T13:32:32.2736438+00:00","created":"2018-03-15T13:24:23.6541868+00:00","updated":"2018-03-15T13:32:32.2736438+00:00"}}

Problem Description:

Output from /api/v1/Update/develop is the latest build of the branch, regardless of pass/fail status.

Reproduction Steps:

Call the update check via API when the latest build in appveyor is failed.

tidusjar added a commit that referenced this issue Mar 16, 2018
@tidusjar tidusjar mentioned this issue Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants