Fix for issue #1907 #2093
Fix for issue #1907 #2093
Conversation
| this.backgroundPath = this.sanitizer.bypassSecurityTrustStyle | ||
| ("url(" + x + ")"); | ||
| }); | ||
| this.searchService.getShowInformationTreeNode(Number(issue.providerId)).subscribe(x => { |
There was a problem hiding this comment.
We probably shouldn't be doing this just to get the banner.
This will pull back ALL the information about the request, and we need to keep in mind that there might not be a request associated with the issue.
We can raise issues on content that do not have requests.
There was a problem hiding this comment.
@tidusjar Good point, I did not think of that. Would writing a few API calls that just returns image paths be the best solution here instead?
For example, I wrote API calls inside image.service.ts but the FanArt banner and poster images were inconsistent with the request or search images. So maybe just writing new API calls for TheMovieDBApi.cs and TvMazeApi.cs to return just the images would work?
There was a problem hiding this comment.
Yes, we have the provider id so we can just use the Image service (check the Image Controller to see what we currently support)
If you are writing a new api then I suggest it should be on the ImageController.
|
Looks good. I can't see anything else here. Have you done the appropriate dev testing to make sure it's functioning correctly? |
|
@tidusjar Yes I have tested as much as I can think of inside VS! |
|
Thanks a lot! |
Implemented bg and poster on issue details page as per issue #1907