Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/request limits #4312

Merged
merged 12 commits into from
Sep 26, 2021
Merged

Feature/request limits #4312

merged 12 commits into from
Sep 26, 2021

Conversation

tidusjar
Copy link
Member

@tidusjar tidusjar commented Sep 22, 2021 •
edited
Loading

Currently a work in progress

  • Backend
  • Frontend

@tidusjar
feat(request-limits): 🎉 Started on the request limits, applied to the…
f5310b7 
… user model
@tidusjar
feat(request-limits): 🗃️ Added new user field migrations to mysql and…
f73bccb 
… sqlite
@tidusjar
feat(request-limits): ✨ Added in the main logic for the new request l…
70d5bf5 
…imits
@tidusjar
test(request-limits): ✅ Added full coverage unit tests for the new re…
847873c 
…quest limits
@tidusjar
feat(request-limits): ✨ Request limits are no longer a rolling date. …
364b9f1 
…But reset at the start of the week or month depending on the preference
@tidusjar
refactor(request-limits): ♻️ Refactored the request limits to sit in …
6adf75d 
…their own services
@tidusjar
feat(request-limits): ✨ Updated the RequestLimit Rules to use the new…
e31ee8d 
… refactored service
@tidusjar
test(request-limits): ✅ Added tests for the new RequestLimitRules
1ba054e
@cypress
Copy link

cypress bot commented Sep 25, 2021


Test summary

96 • 2 • 1 • 0 • Flakiness 1

Run details
Project Ombi Automation
Status Failed
Commit 978d4ea
Started Sep 25, 2021 10:32 PM
Ended Sep 25, 2021 10:44 PM
Duration 11:19 💡
OS Linux Ubuntu - 20.04
Browser Chrome 93

View run in Cypress Dashboard ➡️

Failures

cypress/tests/search/search.spec.ts 2 Failed
1 Search Tests > No TV results, enabling movies filter we get results
2 Search Tests > No Movie results, enabling Tv filter we get results

Flakiness

cypress/tests/discover/discover-cards-requests.spec.ts 1 Flakiness
1 Discover Cards Requests Tests > Available TV (From Details Call) does not allow us to request

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Sep 25, 2021


Test summary

95 • 3 • 1 • 0 • Flakiness 1

Run details
Project Ombi Automation
Status Failed
Commit 07f2c0d ℹ️
Started Sep 25, 2021 10:33 PM
Ended Sep 25, 2021 10:47 PM
Duration 13:42 💡
OS Linux Ubuntu - 20.04
Browser Chrome 93

View run in Cypress Dashboard ➡️

Failures

discover/discover-cards-requests.spec.ts 1 Failed
1 Discover Cards Requests Tests > Not available TV allow non-admin to request
search/search.spec.ts 2 Failed
1 Search Tests > No TV results, enabling movies filter we get results
2 Search Tests > No Movie results, enabling Tv filter we get results

Flakiness

cypress/tests/discover/discover-cards-requests.spec.ts 1 Flakiness
1 Discover Cards Requests Tests > Not available TV allow admin to request

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tidusjar tidusjar merged commit e302cf6 into develop Sep 26, 2021
@tidusjar tidusjar deleted the feature/request-limits branch September 26, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tidusjar