Localize genres filter #4541
Merged
Localize genres filter #4541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sephrat
commented
Mar 8, 2022
| /// Gets the genres for either Tv or Movies depending on media type | ||
| /// </summary> | ||
| /// <param name="media">Either `tv` or `movie`.</param> | ||
| [HttpGet("Genres/{media}")] |
There was a problem hiding this comment.
I moved this to SearchController for convenience (so that I could call DefaultLanguageCode()). It may make less sense for it to be there because the genres ID are TMDB-specific, but since we use these IDs in SearchController as well, I thought this would not smell that much.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for localized genres selection in the advanced search popup, and as a side effect in /Settings/TheMovieDb.