Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscribe button for movies #4585

Merged
merged 8 commits into from
Apr 13, 2022
Merged

Conversation

sephrat
Copy link
Contributor

@sephrat sephrat commented Apr 8, 2022

  • Deprecate 'subscribed' field from search service which could be incorrect because of caching
  • Fixes 'subscribed' field from request service
  • Fixes 'Subscribe' button not being displayed for non-4K setups
  • Allows admins to subscribe too

@tidusjar
Copy link
Member

tidusjar commented Apr 8, 2022

Now we have moved it, does the UI need to now set the properties from the request rather than the search object?

@sephrat
Copy link
Contributor Author

sephrat commented Apr 8, 2022

Now we have moved it, does the UI need to now set the properties from the request rather than the search object?

It's been done here: dd7219e
Or did you mean something else?

@tidusjar
Copy link
Member

tidusjar commented Apr 8, 2022

I missed that. That does make sense. My only issue is that if anyone is depending on that field in the api it’s not going to work. An example of this would be the mobile app. I suggest we put the v1 back for a bit and then later remove it. That way we can stage the rollout.

Let's only flag it as obsolete for now
@sephrat
Copy link
Contributor Author

sephrat commented Apr 9, 2022

Sounds reasonable. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants