-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subscribe button for movies #4585
Conversation
sephrat
commented
Apr 8, 2022
- Deprecate 'subscribed' field from search service which could be incorrect because of caching
- Fixes 'subscribed' field from request service
- Fixes 'Subscribe' button not being displayed for non-4K setups
- Allows admins to subscribe too
This allows for the search service to be cached across all users
Now we have moved it, does the UI need to now set the properties from the request rather than the search object? |
It's been done here: dd7219e |
I missed that. That does make sense. My only issue is that if anyone is depending on that field in the api it’s not going to work. An example of this would be the mobile app. I suggest we put the v1 back for a bit and then later remove it. That way we can stage the rollout. |
Let's only flag it as obsolete for now
Sounds reasonable. Done. |