Disable Autocomplete for Plex Server Dialog #5089
Merged
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have observed an issue where certain password/form-fill managers will automatically fill in old plex server details (such as authentication token or machine identifier). For example, my lastpass seems to be remembering an old authentication token, and without my noticing will auto-fill in those details even when I haven't explicitly told it to. I imagine this happens with other password managers, and I don't see a particular need to autocomplete/auto-fill these details.
I have confirmed that the
autocomplete="off"
is an industry standard for inputs and modern managers will respect it (optionally).Switching to a different browser without lastpass, I have no issues. This might be a Chrome issue, but I don't see any data in my auto-fill settings where this data is being kept. Either way, native browser auto-fill or password manager extension, this causes issues.
There should probably a separate initiative to add this to other input forms throughout at least the settings area of the front end.
Thank you!