Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landingpage.component.html To Page Scrolling. #5127

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Update landingpage.component.html To Page Scrolling. #5127

merged 2 commits into from
Jul 8, 2024

Conversation

ExtremeFiretop
Copy link
Contributor

Update landingpage.component.html To Page Scrolling on mobile devices.

This is to address issue:

#5046

Tested on my mobile with success.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@tidusjar tidusjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The only problem with this is that due to some other content div it seems there's always a scrollbar no matter the viewport size now. Looks like the row in the small-middle-container is causing it oddly enough

@ExtremeFiretop
Copy link
Contributor Author

Thanks for the PR!

The only problem with this is that due to some other content div it seems there's always a scrollbar no matter the viewport size now. Looks like the row in the small-middle-container is causing it oddly enough

I'm sorry if I over-stepped. I was just trying to learn a bit myself and troubleshoot at the same time.
I did mention this was only a workaround in the issue. So if this is not correct please feel free to close.

Otherwise, I can keep poking?

@tidusjar
Copy link
Member

tidusjar commented Jul 8, 2024

It's completely fine! Please feel free to keep poking away :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ExtremeFiretop
Copy link
Contributor Author

Thanks for the PR!

The only problem with this is that due to some other content div it seems there's always a scrollbar no matter the viewport size now. Looks like the row in the small-middle-container is causing it oddly enough

@tidusjar

I believe I fixed it in commit: 18e0d90

Can you test/review and advise?

@ExtremeFiretop
Copy link
Contributor Author

On my desktop with a ultrawide screen at 1440p, I have no scroll bar.
On my phone, I can scroll down to the button even with long text at the landing page.

(I am actually using HTML for the landing page, still no issues though)

@ExtremeFiretop ExtremeFiretop requested a review from tidusjar July 8, 2024 14:57
@tidusjar
Copy link
Member

tidusjar commented Jul 8, 2024

Nice work!

@ExtremeFiretop
Copy link
Contributor Author

ExtremeFiretop commented Jul 8, 2024

Nice work!

Thank you my friend, I'm happy I could learn a bit along the way and provide some assist as well! Always appreciate the work put into this project on your part! :)

@tidusjar tidusjar merged commit 0db5928 into Ombi-app:develop Jul 8, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants