Fix: incorrect type for output_field argument of generate_series function #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
output_field
argument ofgenerate_series
function should be a child class ofmodels.Field
. It is used indjango_generate_series.models._make_model_class
function to validate whether theoutput_field
is of supported fields, whereissubclass
is used for checking. https://github.com/jacklinke/django-generate-series/blob/ae419b9d761b93b59632269dc54252c135ea3fb9/django_generate_series/models.py#L407However, the first argument of
issubclass
must be a class, not an instance. Therefore, the typing is incorrect here.