Lua 5.1 minimum compatibility #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll want to fix our vendored libraries and propose the fixes upstream. |
Co-authored-by: Caleb Maclennan <caleb@alerque.com>
Omikhleia
force-pushed
the
fix-lua51-compat
branch
from
4e961de to
a71357a
Compare
Fixes some minor code and linting errors that were fixed when our PRs to the upstream lunamark library were reviewed.
Global luautf8 module is guaranteed to be provided by SILE. Co-authored-by: Caleb Maclennan <caleb@alerque.com>
In order for us not to add too much bad code when implementing our modifications or extensions...
Omikhleia
force-pushed
the
fix-lua51-compat
branch
from
2a66724 to
eb8984b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Omikhleia/resilient.sile#70