-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally restrict a token to a set of addresses #287
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f1af0a7
First cut at restricting a token to a list of addresses
dacoinminster 027f3bf
Merge branch 'master' of https://github.com/mastercoin-MSC/spec
dacoinminster e466a23
Changes after talking to Zathras about this PR
dacoinminster e6c8c68
Actually need 21 bytes, not 20
dacoinminster d9d94a7
Reverting whitespace-only changes
dacoinminster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language is a bit flawed: a public key hash has a length 20 bytes and used in most standard transaction. Base58 encoding, checksums, versions and so on are "on top". This sounds as if you start from 16UwLL9Risc3QfPqBUvKofHmBQ7wMtjvM to get to 00010966776006953d5567439e5e39f86a0d273bee, but it's actually the other way around. What is "hash step of creating a bitcoin address"?
This helps and is a good overview of the steps involved:
https://en.bitcoin.it/wiki/Technical_background_of_Bitcoin_addresses
Edit: by the way: gratulations for spotting the need of a version byte. I overlooked this. :)