Fix potential unobserved exception in InputHandler.cs (#635)

Co-authored-by: Yannick Cholette <yannick.cholette@ubisoft.com>
OmniSharp · Aug 24, 2021 · de1591e · de1591e
1 parent 89a97d1
commit de1591e
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/JsonRpc/InputHandler.cs b/src/JsonRpc/InputHandler.cs
@@ -110,9 +110,16 @@ IScheduler scheduler
         public void Start()
         {
             _disposable.Add(
-                Observable.FromAsync(() => ProcessInputStream(_stopProcessing.Token))
-                          .Do(_ => { }, e => _logger.LogCritical(e, "unhandled exception"))
-                          .Subscribe(_inputActive)
+                Observable.FromAsync(async () => {
+                    try
+                    {
+                        await ProcessInputStream(_stopProcessing.Token).ConfigureAwait(false);
+                    }
+                    catch (Exception e)
+                    {
+                        _logger.LogCritical(e, "unhandled exception");
+                    }
+                }).Subscribe(_inputActive)
             );
             _disposable.Add(
                 _inputQueue