Skip to content

Misc dap fixes #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Misc dap fixes #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
376a411
fix initializeresponse payload
TylerLeonhardt Sep 5, 2019
0291179
WORKAROUND: set success to true to allow messaging to work for now
TylerLeonhardt Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/Dap.Protocol/Requests/InitializeResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,5 @@

namespace OmniSharp.Extensions.DebugAdapter.Protocol.Requests
{
public class InitializeResponse
{
/// <summary>
/// The capabilities of this debug adapter.
/// </summary>
[Optional] public Capabilities Body { get; set; }
}

public class InitializeResponse : Capabilities {}
}
3 changes: 3 additions & 0 deletions src/JsonRpc/Serialization/DebugAdapterConverters/DapClientResponseConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ public override void WriteJson(JsonWriter writer, Response value, JsonSerializer
writer.WriteValue("response");
writer.WritePropertyName("request_seq");
writer.WriteValue(value.Id);
// TODO: Dynamically set this based on handler execution.
writer.WritePropertyName("success");
writer.WriteValue(true);
writer.WritePropertyName("command");
writer.WriteValue(value.Request?.Method);
if (value.Result != null)
Expand Down