Skip to content

Correctly handle CommandOrCodeAction with missing "command" property #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

Correctly handle CommandOrCodeAction with missing "command" property #211

merged 1 commit into from
Feb 13, 2020

Conversation

tintoy
Copy link
Collaborator

@tintoy tintoy commented Feb 13, 2020

Fixes #210

@tintoy tintoy added the bug Something isn't working label Feb 13, 2020
@tintoy tintoy self-assigned this Feb 13, 2020
TylerLeonhardt
TylerLeonhardt approved these changes Feb 13, 2020
View reviewed changes
Copy link
Collaborator

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so was I right? 😅 Were you able to repro?

@TylerLeonhardt
Copy link
Collaborator

I've just verified this locally - it fixes my issue :)

@TylerLeonhardt TylerLeonhardt mentioned this pull request Feb 13, 2020
Merged
@tintoy tintoy merged commit c8cca33 into OmniSharp:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees

@tintoy tintoy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null ref exception in Client lib
2 participants
@tintoy @TylerLeonhardt