-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set server receiver to initialized
at the end of the initialize
request
#589
Conversation
I'm trying to test this locally but haven't managed to get OmniSharp to build yet 😅 |
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
- Coverage 69.38% 69.37% -0.02%
==========================================
Files 257 257
Lines 12577 12576 -1
Branches 848 848
==========================================
- Hits 8726 8724 -2
- Misses 3581 3582 +1
Partials 270 270
Continue to review full report at Codecov.
|
@david-driscoll I took the bits built by CI, updated my local build to use them, and can no longer repro my bug! I don't want to say I fixed it too soon, but it sure looks like it. I am about to post a VSIX on my issue so others can confirm, and if so, then I think this will be good to go! |
Woo-hoo! @david-driscoll I have multiple users confirming this has completely fixed things. |
Apparently I had to approve for the ci builds to run... weird. |
I'm not sure what to do about the CodeCov part of the build. |
I'm not worried about 0.02% code coverage drop 😄 |
This pulls in OmniSharp/csharp-language-server-protocol#589 which fixes PowerShell/vscode-powershell#3306!
This also appears to have resolved @majastrz's issue #556 and @anthony-c-martin's issue #516 🥳 |
Resolves #588.