Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set server receiver to initialized at the end of the initialize request #589

Merged
merged 1 commit into from
May 20, 2021

Conversation

andyleejordan
Copy link
Contributor

@andyleejordan andyleejordan commented May 19, 2021

Resolves #588.

@dnfadmin
Copy link

dnfadmin commented May 19, 2021

CLA assistant check
All CLA requirements met.

@github-actions github-actions bot added this to the v0.19.2 milestone May 19, 2021
@andyleejordan
Copy link
Contributor Author

I'm trying to test this locally but haven't managed to get OmniSharp to build yet 😅

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #589 (43e58f3) into master (d1daf4b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   69.38%   69.37%   -0.02%     
==========================================
  Files         257      257              
  Lines       12577    12576       -1     
  Branches      848      848              
==========================================
- Hits         8726     8724       -2     
- Misses       3581     3582       +1     
  Partials      270      270              
Impacted Files Coverage Δ
src/Server/LanguageServer.cs 91.89% <ø> (-0.04%) ⬇️
src/Server/LspServerOutputFilter.cs 72.72% <0.00%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1daf4b...43e58f3. Read the comment docs.

@andyleejordan
Copy link
Contributor Author

@david-driscoll I took the bits built by CI, updated my local build to use them, and can no longer repro my bug! I don't want to say I fixed it too soon, but it sure looks like it. I am about to post a VSIX on my issue so others can confirm, and if so, then I think this will be good to go!

@andyleejordan
Copy link
Contributor Author

Woo-hoo! @david-driscoll I have multiple users confirming this has completely fixed things.

@david-driscoll
Copy link
Member

Apparently I had to approve for the ci builds to run... weird.

@andyleejordan
Copy link
Contributor Author

I'm not sure what to do about the CodeCov part of the build.

@david-driscoll
Copy link
Member

I'm not worried about 0.02% code coverage drop 😄

@david-driscoll david-driscoll merged commit 3f56706 into OmniSharp:master May 20, 2021
@github-actions github-actions bot added the mysterious We forgot to label this label May 20, 2021
andyleejordan added a commit to PowerShell/PowerShellEditorServices that referenced this pull request May 20, 2021
@andyleejordan
Copy link
Contributor Author

This also appears to have resolved @majastrz's issue #556 and @anthony-c-martin's issue #516 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential race condition with initialized handler
3 participants