Skip to content

Enable opting out of built-in logger provider. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Enable opting out of built-in logger provider. #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/Server/LanguageServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,16 @@ public LanguageServer(
Stream input,
Stream output,
ILoggerFactory loggerFactory)
: this(input, output, new LspReciever(), new RequestProcessIdentifier(), loggerFactory, new Serializer())
: this(input, output, loggerFactory, addDefaultLoggingProvider: true)
{
}

public LanguageServer(
Stream input,
Stream output,
ILoggerFactory loggerFactory,
bool addDefaultLoggingProvider)
: this(input, output, new LspReciever(), new RequestProcessIdentifier(), loggerFactory, new Serializer(), addDefaultLoggingProvider)
{
}

Expand All @@ -50,11 +59,13 @@ internal LanguageServer(
LspReciever reciever,
IRequestProcessIdentifier requestProcessIdentifier,
ILoggerFactory loggerFactory,
Serializer serializer)
Serializer serializer,
bool addDefaultLoggingProvider)
{
var outputHandler = new OutputHandler(output, serializer);
// TODO: This might not be the best
loggerFactory.AddProvider(new LanguageServerLoggerProvider(this));

if (addDefaultLoggingProvider)
loggerFactory.AddProvider(new LanguageServerLoggerProvider(this));

_reciever = reciever;
_loggerFactory = loggerFactory;
Expand Down