Reloadsolution #101
Reloadsolution #101
Conversation
| @@ -56,5 +60,16 @@ public ProjectInformationResponse CurrentProject(Request request) | |||
| AspNet5Project = aspNet5ProjectItem | |||
| }; | |||
| } | |||
|
|
|||
| [HttpPost("/reloadsolution")] | |||
| [HttpGet("/reloadsolution")] | |||
|
there should probably be a restart or reload method on the project system interface. I think it's not a safe assumption to think that |
|
I agree with @filipw is this open to memory leaks? |
|
Doesn't seem to be working. I tried adding a new file and then followed that with a reload. I asked @cubitouch to submit it so I could test. It was an experiment :) |
|
So, I will start over following that list:
|
|
@cubitouch sounds good. At the very minimum, your code should compile ;) After that, I would expect adding new files, projects, deleting files, should just work after firing the reloadsolution command. |
| @@ -416,7 +416,7 @@ private void TriggerDependeees(string path) | |||
| } | |||
| } | |||
|
|
|||
| private void Initialize() | |||
| private void Startup() | |||
There was a problem hiding this comment.
What is Startup? That's a bad name.
There was a problem hiding this comment.
@davidfowl I don't know more than you... There was a public Initalize() (without the 'i') method on the Interface which I renamed Initialize() (as it should be, IMHO). But there was already a private method with that name so I renamed it too (the Startup one).
What name would you like me to use ? Do you want me to rollback these changes and let the Initalize() method like that ?
|
I've been testing this. It doesn't work reliably yet. Sometimes it works just like you'd expect, but other times it causes intellisense to stop working for the entire solution. |
|
Is this totally random or some cases just do not work ? |
|
I have no idea what is causing the issue because I didn't debug. I spent quite a while testing this though. Please test this yourself. |
|
@cubitouch this has been stalled for more than a year. Is this PR still valid? |
|
@troydai no I don't think so, I close it. |
Adding a "/reloadsolution" endpoint to solve this issue : #19