Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential null-ref in MSBuild discovery #1189

Merged
merged 2 commits into from
May 16, 2018

Conversation

DustinCampbell
Copy link
Contributor

@DustinCampbell DustinCampbell commented May 16, 2018

Fixes #1188

This fixes a null-reference extension that can be thrown if the "VSINSTALLDIR" environment variable exists but "VSCMD_VER" does not.

This fixes a null-reference extension that can be thrown if the "VSINSTALLDIR" environment variable exists but "VSCMD_VER" does not.
@DustinCampbell
Copy link
Contributor Author

cc @rainersigwald

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@filipw filipw merged commit 689cd9b into OmniSharp:master May 16, 2018
@DustinCampbell DustinCampbell deleted the fix-issue-1188 branch May 16, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullReferenceException when OmniSharp server starts
2 participants