Fix diagnostics from loaded cake files shown in the current file #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @jnm2 |
jnm2
reviewed
May 24, 2018
|
|
||
| bool PathsAreEqual(string x, string y) | ||
| { | ||
| if (x == null && y == null) |
There was a problem hiding this comment.
Could be ReferenceEquals(x, y) to be even more efficient in case the same string instance happens to be reused.
jnm2
reviewed
May 24, 2018
| { | ||
| return true; | ||
| } | ||
| if (x == null || y == null) |
There was a problem hiding this comment.
Another tip I had from a contributor at corefx was that x == null | y == null performs better than the branch introduced by ||. Not that this is performance-critical though.
bjorkstromm
force-pushed
the
fix/cake-loaded-codecheck-error
branch
from
7f84c60 to
e740da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported here