added support for TreatWarningsAsErrors in csproj #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorkstromm
approved these changes
Apr 14, 2019
rchande
reviewed
Apr 17, 2019
| @@ -57,8 +57,12 @@ public async Task HelloWorld_has_correct_property_values() | |||
| Assert.Equal("obj/Debug/netcoreapp2.1/", projectFileInfo.IntermediateOutputPath.EnsureForwardSlashes()); | |||
There was a problem hiding this comment.
Probably would also be good to add a test for the actual diagnostics we report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we do not respect
<TreatWarningsAsErrors>setting in csproj file and even if build correctly reports errors, we still show warnings only in the editor.This is a bit ironic, because OmniSharp itself uses
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>- and we do not catch our own warnings 😀This PR fixes that.