updated to Roslyn 3.3.0-beta2-19401-05 to address a StackOverflowException #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this fixes the issue discussed here: #1550 (comment) |
bjorkstromm
approved these changes
Aug 5, 2019
|
Nice find. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update to Roslyn
3.3.0-beta2-19376-02we introduced a criticalStackOverflowExceptionwhen performing code analysis on partial classes.This is a bug described in dotnet/roslyn#37567
It was fixed in dotnet/roslyn#37623 and is available in
3.3.0-beta2-19401-05.We should merge this and release 1.34.2 soonest as the current version is unusable with analyzers+partial classes.
cc @akshita31 @jonsequitur who lured us into updating to that specific build in the first place 😀