Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade GitVersion to 5.0.1 (fixes build on Ubuntu 18.04 and other distros) #1611

Merged
merged 3 commits into from
Sep 26, 2019

Conversation

filipw
Copy link
Member

@filipw filipw commented Sep 26, 2019

This fixes the build crash with GitVersion on Ubuntu 18.04

fixes #1548
fixes #1500
fixes #1251
fixes #1202
fixes #1048

@filipw filipw changed the title upgrade GitVersion to 5.1.0 (fixes build on Ubuntu 18.04 and other distros) upgrade GitVersion to 5.0.1 (fixes build on Ubuntu 18.04 and other distros) Sep 26, 2019
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are updating GitVersion, maybe also update version run AzDo https://github.com/OmniSharp/omnisharp-roslyn/blob/master/azure-pipelines.yml#L14

@david-driscoll what is the reason this is separated?

@filipw
Copy link
Member Author

filipw commented Sep 26, 2019

ah good find thanks.
what's funny is that I remember clearly @david-driscoll explaining to me why it's split like this in azure devops but I forgot now why 😂

Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjorkstromm
Copy link
Member

ah good find thanks.
what's funny is that I remember clearly @david-driscoll explaining to me why it's split like this in azure devops but I forgot now why 😂

Yeah, I also remember that it was split, just not the why 😄

@filipw filipw merged commit 56ffa9f into OmniSharp:master Sep 26, 2019
@filipw filipw deleted the bugfix/ubuntu-18.04 branch September 26, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants