updated to Roslyn 3.4.0-beta3-19516-01 #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
requested review from
JoeRobich,
david-driscoll,
rchande and
bjorkstromm
filipw
force-pushed
the
feature/roslyn-update
branch
from
cc8cdc3 to
8461fa2
Compare
|
This also fixes #1619. I added a negative test so that we don't regress on a closed bug. |
|
@david-driscoll are you ok with merging this? |
|
Yeah ship it
…On Thu, Oct 17, 2019 at 4:01 PM Filip W ***@***.***> wrote:
@david-driscoll <https://github.com/david-driscoll> are you ok with
merging this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1634?email_source=notifications&email_token=AAJV3JM4S7WEK6BTAMF6YMDQPDACHA5CNFSM4JBLYAB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBRK6VI#issuecomment-543338325>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJV3JK5SHNU7SFUZFAQIB3QPDACHANCNFSM4JBLYABQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have fallen behind the schedule a bit (especially with .NET Core 3.1 Preview 1 out already). We had consumed
3.4.0-beta1-19460-02over a month ago but even Nuget publicly has a newer version now.This PR pulls in the latest build intended for VS 16.4.