Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise default GotoDefinitionRequest timeout from 2s to 10s #2032

Merged
merged 1 commit into from
Dec 5, 2020
Merged

raise default GotoDefinitionRequest timeout from 2s to 10s #2032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OmniSharp.Abstractions/Models/v1/GotoDefinition/GotoDefinitionRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace OmniSharp.Models.GotoDefinition
[OmniSharpEndpoint(OmniSharpEndpoints.GotoDefinition, typeof(GotoDefinitionRequest), typeof(GotoDefinitionResponse))]
public class GotoDefinitionRequest : Request
{
public int Timeout { get; set; } = 2000;
public int Timeout { get; set; } = 10000;
public bool WantMetadata { get; set; }
}
}
2 changes: 1 addition & 1 deletion src/OmniSharp.Roslyn.CSharp/Services/ExternalSourceServiceFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public IExternalSourceService Create(OmniSharpOptions omniSharpOptions)
public CancellationToken CreateCancellationToken(OmniSharpOptions omniSharpOptions, int timeout)
{
var enableDecompilationSupport = omniSharpOptions.RoslynExtensionsOptions.EnableDecompilationSupport;
// since decompilation is slower, use a larger cancellation time (default is 2s per request)
// since decompilation is slower, use a larger cancellation time
var cancellationTimeout = enableDecompilationSupport
? timeout <= 10000 ? 10000 : timeout // minimum 10s for decompilation
: timeout; // request defined for metadata
Expand Down