long paths fix - add app.manifest to stdio driver #2298
Conversation
|
|
There was a problem hiding this comment.
@aburgett87 Thanks for submitting this fix. Just had a few questions about the manifest. Other than that, we would also need a manifest for the OmniSharp.Http.Driver project. Would you be willing to add one for it as well?
|
|
||
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> | ||
| <assemblyIdentity version="1.0.0.0" name="MyApplication.app"/> | ||
| <trustInfo xmlns="urn:schemas-microsoft-com:asm.v2"> |
There was a problem hiding this comment.
Why is the trustInfo section necessary?
There was a problem hiding this comment.
I don't believe it's necessary, I'll remove and re-submit
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | ||
|
|
||
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> | ||
| <assemblyIdentity version="1.0.0.0" name="MyApplication.app"/> |
There was a problem hiding this comment.
Do we need an assemblyIdentity element? If so, should the version and name match the assembly generated by the OmniSharp.Stdio.Driver project?
There was a problem hiding this comment.
@JoeRobich The assemblyIdentity element is required - https://docs.microsoft.com/en-us/windows/win32/sbscs/application-manifests.
Okay, I'll look into how I get this apart of the build process
No problem at all |
There was a problem hiding this comment.
marking as blocked until the assembly identity and version are addressed - #2298 (comment)
thanks!
This is to fix "Could not find a part of the path" issue (#2261)
The manifest was adapted from the manifest that is in v1.37.17 executable