-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable OmniSharp.Cake tests for .NET 6 #2307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Looks like there are some test failures. |
looks like some of the tests deadlocked (?) |
This error in the failing MacOS leg looks suspicious.
|
Hmm, we don't have Mono at all in the .NET 6 tests I assume. Cake.Bakery itself is a .NET 6 console app, but it includes a wrapper for Mono. I'll add a check if we are running Mono or .NET6 and launch the appropriate executable based on runtime. |
I merged this, although I hope this deadlock is now really gone and not that the checks just passed 'accidentally' 😅 |
No description provided.