Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OmniSharp.Cake tests for .NET 6 #2307

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

bjorkstromm
Copy link
Member

No description provided.

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@333fred
Copy link
Contributor

333fred commented Dec 9, 2021

Looks like there are some test failures.

@filipw
Copy link
Member

filipw commented Dec 9, 2021

looks like some of the tests deadlocked (?)

@JoeRobich
Copy link
Member

This error in the failing MacOS leg looks suspicious.

[fail]: OmniSharp.WorkspaceInitializer
         The project system 'OmniSharp.Cake.CakeProjectSystem' threw exception during initialization.
 System.ComponentModel.Win32Exception (8): An error occurred trying to start process '/Users/runner/work/omnisharp-roslyn/omnisharp-roslyn/test-assets/test-projects/CakeProject/tools/Cake.Bakery.0.9.0/tools/Cake.Bakery.exe' with working directory '/Users/runner/work/omnisharp-roslyn/omnisharp-roslyn/test-assets/test-projects/CakeProject'. Exec format error

@bjorkstromm
Copy link
Member Author

This error in the failing MacOS leg looks suspicious.

[fail]: OmniSharp.WorkspaceInitializer
         The project system 'OmniSharp.Cake.CakeProjectSystem' threw exception during initialization.
 System.ComponentModel.Win32Exception (8): An error occurred trying to start process '/Users/runner/work/omnisharp-roslyn/omnisharp-roslyn/test-assets/test-projects/CakeProject/tools/Cake.Bakery.0.9.0/tools/Cake.Bakery.exe' with working directory '/Users/runner/work/omnisharp-roslyn/omnisharp-roslyn/test-assets/test-projects/CakeProject'. Exec format error

Hmm, we don't have Mono at all in the .NET 6 tests I assume. Cake.Bakery itself is a .NET 6 console app, but it includes a wrapper for Mono. I'll add a check if we are running Mono or .NET6 and launch the appropriate executable based on runtime.

@filipw filipw merged commit 30d6395 into OmniSharp:master Jan 11, 2022
@filipw
Copy link
Member

filipw commented Jan 11, 2022

I merged this, although I hope this deadlock is now really gone and not that the checks just passed 'accidentally' 😅

@bjorkstromm bjorkstromm deleted the feature/cake-tests-net6 branch October 5, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants