Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate more instances of IWorkspaceOptionsProvider #2343

Merged
merged 7 commits into from
Mar 8, 2022
Merged

Eliminate more instances of IWorkspaceOptionsProvider #2343

merged 7 commits into from
Mar 8, 2022

Conversation

tmat
Copy link
Contributor

@tmat tmat commented Feb 11, 2022 •
edited
Loading

All options are now passed explicitly to the APIs that need them, except for default values for editorconfig-based formatting options. These will be eliminated later on.

Requires Roslyn changes: dotnet/roslyn#59469

@tmat tmat mentioned this pull request Feb 11, 2022
Merged
1 task
@tmat
Copy link
Contributor Author

tmat commented Feb 11, 2022 •
edited
Loading

@JoeRobich @ryzngard @333fred

@tmat tmat force-pushed the OptionsExternalAccess branch from 6fa1003 to e68fa67 Compare February 23, 2022 20:33
@tmat tmat force-pushed the OptionsExternalAccess branch from e68fa67 to 741ea40 Compare February 25, 2022 17:42
@tmat tmat marked this pull request as ready for review February 25, 2022 19:50
@tmat tmat changed the title Eliminate IWorkspaceOptionsProvider Eliminate more instances of IWorkspaceOptionsProvider Feb 25, 2022
@JoeRobich JoeRobich mentioned this pull request Mar 3, 2022
Closed
@JoeRobich JoeRobich force-pushed the OptionsExternalAccess branch from 625ebe1 to 9a8b09f Compare March 8, 2022 02:51
@JoeRobich
Copy link
Member

@333fred @tmat I updated with a build of Roslyn that includes Gen's change. Feedback welcome on 43ca318

genlu
genlu approved these changes Mar 8, 2022
View reviewed changes
Copy link

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completion part LGTM

@333fred 333fred merged commit 696cf21 into OmniSharp:master Mar 8, 2022
@filipw filipw mentioned this pull request Apr 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@genlu genlu genlu approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmat @JoeRobich @genlu @333fred