Update Roslyn to 4.5.0-2.22527.10 #2486
Conversation
| @@ -59,6 +59,12 @@ | |||
| <PackageReference Update="Microsoft.VisualStudio.Setup.Configuration.Interop" Version="1.14.114" /> | |||
| <PackageReference Update="Microsoft.VisualStudio.SDK.EmbedInteropTypes" Version="15.0.12" /> | |||
|
|
|||
| <!-- The two references below can be deleted once OmniSharp.Extensions.LanguageServer | |||
There was a problem hiding this comment.
O#-roslyn and Razor both indirectly reference Microsoft.VisualStudio.Validation:
- O#-roslyn via
OmniSharp.Extensions.LanguageServer->OmniSharp.Extensions.JsonRpc->Nerdbank.Streams->Microsoft.VisualStudio.Threading->Microsoft.VisualStudio.Validation - Razor via
Microsoft.VisualStudio.Threading->Microsoft.VisualStudio.Validation
Razor is on a 17.xx version of Microsoft.VisualStudio.Validation, while O#-roslyn is on a lower version. We need to bump O#-roslyn's version to avoid errors in Razor files. However, the newest version of OmniSharp.Extensions.LanguageServer only utilizes a Validation version of 16.xx, so we have to bump explicitly until they update to a newer version.
|
|
||
| <PackageReference Update="SQLitePCLRaw.bundle_green" Version="2.0.7" /> | ||
| <PackageReference Update="SQLitePCLRaw.bundle_green" Version="2.1.0" /> |
There was a problem hiding this comment.
Was seeing build warnings until I bumped this version
| // The completion is somehow expensive. Currently, this one of two categories: import completion, or override/partial | ||
| // completion. | ||
| // To-do: Add support for snippet items: https://github.com/OmniSharp/omnisharp-roslyn/issues/2485 | ||
| if (completion.GetProviderName() == SnippetCompletionProvider) |
There was a problem hiding this comment.
Including snippets seems to be causing duplicate items in the completion list, so skipping for now.
| @@ -211,7 +209,7 @@ public async Task When_custom_rule_is_set_to_none_dont_return_results_at_all() | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| [Fact(Skip = "https://github.com/dotnet/roslyn/issues/66085")] | |||
There was a problem hiding this comment.
The underlying issue here has been fixed (thanks Manish!), however the fix is in a newer version of Roslyn, so skipping the test for now
| } | ||
|
|
||
| public override ImmutableArray<ISourceGenerator> GetGenerators(string language) | ||
| => ImmutableArray.Create<ISourceGenerator>(new TestSourceGenerator(_execute)); | ||
| => _generators; |
There was a problem hiding this comment.
This originally caused a test failure due to changes from dotnet/roslyn#64729. The fix is to not create a new generator each time these methods are called, and instead re-use the existing generator in order to maintain the same documentId.
This upgrade is needed for compatibility with Razor.