Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for new .net core csproj guid in .sln files. #675

Conversation

danwalmsley
Copy link
Contributor

No description provided.

@danwalmsley danwalmsley changed the title add support for new .net core csproj guid in .sln files. WIP: add support for new .net core csproj guid in .sln files. Nov 22, 2016
@danwalmsley danwalmsley changed the title WIP: add support for new .net core csproj guid in .sln files. add support for new .net core csproj guid in .sln files. Nov 24, 2016
@danwalmsley
Copy link
Contributor Author

I have tested this now and can confirm this fixes compatibility issue with new csproj guids.

@willl
Copy link
Member

willl commented Nov 24, 2016

@danwalmsley But it has a dependency on the upgraded MS Build from @DustinCampbell's branch, right?

@DustinCampbell
Copy link
Contributor

Yep. @danwalmsley: You should probably rebase and resubmit for the new-msbuild branch.

@DustinCampbell DustinCampbell changed the base branch from dev to new-msbuild December 5, 2016 15:16
@DustinCampbell
Copy link
Contributor

I went ahead and rebased this on the new-msbuild branch.

@DustinCampbell DustinCampbell merged commit 351b373 into OmniSharp:new-msbuild Dec 5, 2016
@DustinCampbell
Copy link
Contributor

Thanks for the PR @danwalmsley! Sorry it took so long to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants