MSBuild unit test refactoring #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est!) This is a fairly significant change in that it adds our first MSBuild project test. This requires some gymnastics to ensure that MSBuild.exe can to set up MSBuild's build environment. In the tests, we set the MSBUILD_EXE_PATH environment variable to properly locate MSBuild during test runs.
|
It's likely that the CI build will fail when running tests for MSBuild on net46. I'm guessing I'll need to disable that for now. |
|
Ugh. The new MSBuild unit test fails on OSX/Linux because it needs to be restored first to get the targets and packages. However, because we build with an older version of the .NET CLI, restore won't work for the csproj. 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the first MSBuild project unit test and unifies the "sample projects" into a top-level folder called "test-assets"