replaced InteractiveScriptGlobals with CommandLineScriptGlobals as CSX host object type
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
commented
May 2, 2017
| "Prin$$"; | ||
|
|
||
| var completions = await FindCompletionsAsync("dummy.csx", source); | ||
| ContainsCompletions(completions.Select(c => c.CompletionText), new[] { "Print", "PrintOptions" }); |
There was a problem hiding this comment.
note that we are ahead of VS 😃
dotnet/roslyn#13886
There was a problem hiding this comment.
Yeah, VS Code scripting support is well ahead of VS. You're doing great work! 👍
DustinCampbell
approved these changes
May 3, 2017
| "Prin$$"; | ||
|
|
||
| var completions = await FindCompletionsAsync("dummy.csx", source); | ||
| ContainsCompletions(completions.Select(c => c.CompletionText), new[] { "Print", "PrintOptions" }); |
There was a problem hiding this comment.
Yeah, VS Code scripting support is well ahead of VS. You're doing great work! 👍
|
looks like I got into conflicts with myself 😄 |
|
I rebased this and resolved the conflicts - should be good to go |
david-driscoll
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
InteractiveScriptGlobalswithCommandLineScriptGlobalsas CSX host object type. This is required, because CSI usesCommandLineScriptGlobalsas host object for CSX script execution.InteractiveScriptGlobalsis only used for REPL mode (reference), so naturally it makes sense to offerCommandLineScriptGlobalsin OmniSharp intellisense.As a bonus, I extracted some of the project/compilation set up logic from
ScriptProjectSystemintoScriptHelper. This way, it can be used in the tests as well, to ensure that the test set up is using the same logic as the project system would. This makes tests more reliable than before, where the code to create CSX project/compilation was maintained in tests separately and needed to always stay in sync with project system to be trustworthy.