LA-224 Added '/file/{fid}/version/{vid}' to auto-launch schema #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAD
commented
Oct 3, 2024
|
@JohnAD Make sure that URL pattern is |
It wasn't. I was thinking it did not have the "/version/" in the middle. I've sent an updated commit. |
JohnAD
changed the title
pieterhijma
requested changes
Oct 8, 2024
pieterhijma
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://ondsel-brad.atlassian.net/browse/LA-224?atlOrigin=eyJpIjoiYTBkNTNlNWM3YmIyNDM5MjhmMmY1ZTRlN2IyMDlkMTEiLCJwIjoiaiJ9 for detail.
Also adds many of the remaining data models to
/models. Needed for pulling file and version details.Also refactors the shared-model download handling somewhat to make more robust.