Temporarily turn off the weather image feature to fix a crash

Workaround for #1196
OneBusAway · Apr 2, 2024 · 76aefc1 · 76aefc1
1 parent cf499e3
commit 76aefc1
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 16 deletions.
diff --git a/onebusaway-android/build.gradle b/onebusaway-android/build.gradle
@@ -39,8 +39,8 @@ android {
     defaultConfig {
         minSdkVersion 21
         targetSdkVersion 33
-        versionCode 140
-        versionName "2.13.0"
+        versionCode 141
+        versionName "2.13.1"
 
         multiDexEnabled true
 

diff --git a/onebusaway-android/src/main/java/org/onebusaway/android/ui/weather/WeatherUtils.java b/onebusaway-android/src/main/java/org/onebusaway/android/ui/weather/WeatherUtils.java
@@ -13,21 +13,24 @@
 public class WeatherUtils {
 
     public static void setWeatherImage(ImageView imageView, String weatherCondition, Context context) {
+        // TODO FIXME: This is temporarily commented out because it was causing a large number
+        // of crashes in 2.13.0.
+        // See https://github.com/OneBusAway/onebusaway-android/issues/1196
 
-        String resName = weatherCondition.replace("-", "_");
-        
-        int resId = context.getResources().getIdentifier(resName, "drawable", context.getPackageName());
-        
-        if (resId != 0) {
-            // Adjusting scale for fog and wind icons.
-            if(weatherCondition.equals("fog") || weatherCondition.equals("wind")){
-                imageView.setScaleType(ImageView.ScaleType.CENTER);
-            }
-            imageView.setImageResource(resId);
-        } else {
-            // Default
-            imageView.setImageResource(R.drawable.clear_day);
-        }
+//        String resName = weatherCondition.replace("-", "_");
+//
+//        int resId = context.getResources().getIdentifier(resName, "drawable", context.getPackageName());
+//
+//        if (resId != 0) {
+//            // Adjusting scale for fog and wind icons.
+//            if(weatherCondition.equals("fog") || weatherCondition.equals("wind")){
+//                imageView.setScaleType(ImageView.ScaleType.CENTER);
+//            }
+//            imageView.setImageResource(resId);
+//        } else {
+//            // Default
+//            imageView.setImageResource(R.drawable.clear_day);
+//        }
     }
 
     public static void setWeatherTemp(TextView weatherTempTxtView, double temp) {

diff --git a/onebusaway-android/src/main/res/layout/main.xml b/onebusaway-android/src/main/res/layout/main.xml
@@ -109,6 +109,7 @@
 
                         <ImageView
                             android:id="@+id/weatherStateImageView"
+                            android:visibility="gone"
                             android:layout_width="24dp"
                             android:layout_height="24dp"
                             android:scaleType="centerCrop"